broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision.
REVISION SUMMARY Operate on `QRectF`/`QSizeF` and only round back to integer at the end. TEST PLAN I've always been under the impression that the previews in icons kcm were misaligned or cut off slightly. Before F7796401: Screenshot_20191202_155753.png <https://phabricator.kde.org/F7796401> After F7796402: Screenshot_20191202_155733.png <https://phabricator.kde.org/F7796402> - Notification thumbnail strip (qpixmapitem) still works - QR code in klipper (qimageitem) still works REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25685 AFFECTED FILES src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp To: broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
