dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kcolorscheme.cpp:289
> struct {
> - QBrush fg[8], bg[8], deco[2];
> + QBrush fg[KColorScheme::NForegroundRoles],
> bg[KColorScheme::NBackgroundRoles], deco[KColorScheme::NDecorationRoles];
> } _brushes;
(I would split this into 3 lines for more readability)
> kcolorscheme.cpp:742
> +
> +
extra empty lines added at the end?
REPOSITORY
R265 KConfigWidgets
BRANCH
arcpatch-D25677 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25677
To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
