chinmoyr added inline comments. INLINE COMMENTS
> dfaure wrote in slaveinterface_p.h:56 > Please explain how, for when the time comes (in case you're not around to do > it). Removing each of its occurence (of which there are 3) and the surrounding `if`. I will add comments where its needed to be removed. > dfaure wrote in jobuidelegate.h:155 > what would be the proper API you have in mind? I think adding a QString parameter for operation details should be sufficient. Then the API should be kept in sync with SlaveBase, SalveInterface, and JobUiDelegateExtension. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
