apol added a comment.

  LGTM otherwise

INLINE COMMENTS

> kiconloader.cpp:564
>      const QString newThemeName = sharedConfig->group("Icons")
> -                                               .readEntry("Theme", 
> QString());
> +                                               .readEntry("Theme", 
> QString("breeze"));
>      if (!newThemeName.isEmpty()) {

QStringLiteral

> kicontheme.cpp:607
>          KConfigGroup cg(KSharedConfig::openConfig(), "Icons");
> -        theme = cg.readEntry("Theme", QString());
> +        theme = cg.readEntry("Theme", QString("breeze"));
>      }

QStringLiteral

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26044

To: bport, #plasma, ervin, crossi
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to