broulik created this revision. broulik added reviewers: Frameworks, VDG, Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision.
REVISION SUMMARY This includes: - Rendering hidden items desaturated when in "show all" mode - A getter for "show all" - Signals for place activation/clicking - Signals for middle clicking a place (for e.g. open in a new tab) - Possibility to add custom actions to the context menu - Possibility to provide own storage teardown procedure - Changing view icon size is forwarded to delegates The delegates are also made somewhat more compact to match Dolphin and spacing inbetween sections increased. TEST PLAN Try with branch `broulik/kfileplacesview` in Dolphin. - Can I remove a `Q_PRIVATE_SLOT`? - Currently when enabling "show all" and clicking a place, "show all" is deactivated again. Dolphin keeps this permanently. Should we change this? Dolphin (from left to right: current custom view, `KFilePlacesView` current look, `KFilePlacesView` more compact new look to match Dolphin) F7822829: Screenshot_20191217_162724.png <https://phabricator.kde.org/F7822829> Open dialog (from left to right: current look, more compact look, imho looks a bit crowded in conjunction with the file dialog :/0 F7822826: Screenshot_20191217_162838.png <https://phabricator.kde.org/F7822826> REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26067 AFFECTED FILES src/filewidgets/kfileplacesview.cpp src/filewidgets/kfileplacesview.h src/filewidgets/kfileplacesview_p.h To: broulik, #frameworks, #vdg, #dolphin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns