ngraham added a comment.
Much better now, thanks. There's just one more thing I only notices now,
sorry. Then I think it'll be good to go.
INLINE COMMENTS
> kpropertiesdialog.cpp:1452
> +{
> + const QUrl url = properties->url();
> +
Instead of defining this as a variable that's used only once, you can just
directly access the value from `properties->url()` in the `KRun::run()` function
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
