On Mon, 2007-12-24 at 19:11 +0200, Andriy Gapon wrote: > on 24/12/2007 16:32 Andriy Gapon said the following: > > on 21/12/2007 15:33 Joe Marcus Clarke said the following: > >> Disc media is treated differently than USB media. USB umass devices are > >> assumed to have media. This is part of the issue with the card reader > >> (floppy drives behave the same way). > > > > Isn't this a bad assumption? > > Attached is a patch that attempts to address removable storage devices > (that are not CD-ROMs) attached either via SCSI or via USB. The purpose > is to do "gentler" probing of media presence than that done by OS in > response to open(2). > I employed one hack in the code to avoid device being open()-ed if > cam_open_device() fails, but this was "just in case", not sure if it was > really needed. > > The patch works very well for me, especially in tandem with the patch > for SCSI verboseness that I posted to -stable and -scsi.
Committed with a change to check that the driver is one of da, sa, or cd when the bus type is USB (we now have ATA USB support as well). I also changed the cdrom variable name to scsi_device as we aren't necessarily dealing with cdrom devices in all cases. The functionality should not be changed, though. Thanks for doing this. Joe -- Joe Marcus Clarke FreeBSD GNOME Team :: [EMAIL PROTECTED] FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome
signature.asc
Description: This is a digitally signed message part
_______________________________________________ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd