When upgrading the ports on my desktop at home recently I found it quite a bit
of a POLA violation that CUPS support was not enabled by default. It looks
like you already DTRT for packages, so would you be opposed to just always
DTRT if the user hasn't explicitly disabled CUPS? That is:
Index: devel/qt4/files/Makefile.options
===================================================================
RCS file: /home/ncvs/ports/devel/qt4/files/Makefile.options,v
retrieving revision 1.3
diff -u -r1.3 Makefile.options
--- devel/qt4/files/Makefile.options 25 Mar 2011 09:54:15 -0000 1.3
+++ devel/qt4/files/Makefile.options 12 Jun 2012 21:27:38 -0000
@@ -5,10 +5,7 @@
# without making qt4-corelib depend on useless stuff. Both qt4-corelib
# and qt4-gui must be recompiled when changing options.
QT4_OPTIONS_ALL=CUPS NAS QGTKSTYLE
-QT4_OPTIONS?=
-.if defined(PACKAGE_BUILDING)
-QT4_OPTIONS+= CUPS
-.endif
+QT4_OPTIONS?= CUPS
.for opt in ${QT4_OPTIONS_ALL}
${opt}_REPLACE=
This seems to be a simple way to restore POLA. Users who don't want CUPS can
always put 'QT4_OPTIONS=' in their /etc/make.conf (or on the command line).
--
John Baldwin
_______________________________________________
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information
