----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6393/#review9664 -----------------------------------------------------------
/trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/networkinterface.h <http://svn.reviewboard.kde.org/r/6393/#comment10753> APIDOX (same as above) /trunk/KDE/kdebase/workspace/libs/solid/control/networkinterface.h <http://svn.reviewboard.kde.org/r/6393/#comment10752> APIDOX :) - Sebastian On Jan. 21, 2011, 8:41 a.m., Gökcen Eraslan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6393/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2011, 8:41 a.m.) > > > Review request for Solid. > > > Summary > ------- > > KDE NetworkManagement UI now uses DeactivateConnection method of > org.freedesktop.NetworkManager interface[1] to disconnect given interface but > this is wrong, because when this method is used, NM tries to reconnect to > another autoconnect-enabled connection. Right way of disconnecting is calling > Disconnect method of the org.freedesktop.NetworkManager.Device interface[2]. > > Attached patch adds disconnect method to Solid::Control::NetworkInterface, > Solid::Control::Ifaces::NetworkInterface classes and NM backend. Also dummy > methods are added to wicd and fakenet backends. > > (Thanks to Lamarque for the final fix.) > > [1] > http://projects.gnome.org/NetworkManager/developers/spec-08.html#org.freedesktop.NetworkManager > [2] > http://projects.gnome.org/NetworkManager/developers/spec-08.html#org.freedesktop.NetworkManager.Device > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/libs/solid/control/backends/fakenet/fakenetworkinterface.h > 1216076 > > /trunk/KDE/kdebase/workspace/libs/solid/control/backends/fakenet/fakenetworkinterface.cpp > 1216076 > /trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/networkinterface.h > 1216076 > /trunk/KDE/kdebase/workspace/libs/solid/control/networkinterface.h 1216076 > /trunk/KDE/kdebase/workspace/libs/solid/control/networkinterface.cpp > 1216076 > > /trunk/KDE/kdebase/workspace/solid/networkmanager-0.7/dbus/nm-deviceinterface.h > 1216076 > /trunk/KDE/kdebase/workspace/solid/networkmanager-0.7/networkinterface.h > 1216076 > /trunk/KDE/kdebase/workspace/solid/networkmanager-0.7/networkinterface.cpp > 1216076 > /trunk/KDE/kdebase/workspace/solid/wicd/networkinterface.h 1216076 > /trunk/KDE/kdebase/workspace/solid/wicd/networkinterface.cpp 1216076 > > Diff: http://svn.reviewboard.kde.org/r/6393/diff > > > Testing > ------- > > > Thanks, > > Gökcen > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
