----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106378/#review19447 -----------------------------------------------------------
Ship it! Ship It! - Lukáš Tinkl On Sept. 12, 2012, 5:07 p.m., Alberto Villa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106378/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 5:07 p.m.) > > > Review request for Solid. > > > Description > ------- > > Current hack to check for Removable property in StorageAccess devices goes up > only one level to search for the StorageDrive device. This works fine with > UDev, but not with HAL, which can have (at least on FreeBSD, where I'm > testing it) a StorageVolume device in the middle. Going up the whole tree of > the Block device ensures that we eventually get to the StorageDrive one to > fetch the correct Removable property. > > While here, I'd like to set both Removable and Hotpluggable properties (as > done few lines above), as they are exclusive and have a very different > meaning (Removable being stuff that can be removed while its device node > survives, like CDs and floppies, and Hotpluggable being stuff like USB and > eSATA devices, which can be removed while the system is running without > leaving behind a stale device node). Plasmoids using the dataengine should > check for both the properties, as they shouldn't be defined at the same time > (we're using them in the wrong way, according to the HAL spec which, I guess, > inspired the Solid interface; it's not a big problem, but the code should > handle the correct usage too, as a future devd backend might follow it). > > If approved, I'd like to commit this also to 4.9. > > > Diffs > ----- > > plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 86f123c > > Diff: http://git.reviewboard.kde.org/r/106378/diff/ > > > Testing > ------- > > Tested successfully on FreeBSD 10-CURRENT r239665 with KDE SC 4.9.0: my USB > flash drives now appear in the device notifier plasmoid (and a console.log() > in the plasmoid itself confirms that the device now has the Removable > property). > > I also double-checked with a UDev-backed `solid-hardware list details` log > that the logic correctly applies to UDev. > > > Thanks, > > Alberto Villa > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
