----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106783/#review20136 -----------------------------------------------------------
Besides the fact that I like the principle of the idea, I am not sure whether the approach of hiding works better than disabling. I am saying this since it's quite common to have people unplugging their battery at times to save some of its lifecycle. Hence, the fact that batteryCount == 0 might also mean that the battery is simply unplugged, and maybe if that's the case having the fields simply disabled might make more sense. What do you think? - Dario Freddi On Oct. 10, 2012, 2:36 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106783/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2012, 2:36 p.m.) > > > Review request for Solid. > > > Description > ------- > > This little patch hides the config options for battery levels altogether when > there is no battery present. Reducses visual clutter. > > > Diffs > ----- > > powerdevil/kcmodule/global/GeneralPage.cpp 5ff3f4d > powerdevil/kcmodule/global/generalPage.ui 7840526 > > Diff: http://git.reviewboard.kde.org/r/106783/diff/ > > > Testing > ------- > > Didn’t test whether the elements are really hidden in the real condition > (Have a notebook only here, but I know that if works) but commented out the > if and the elements are all properly removed. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
