-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107117/
-----------------------------------------------------------
(Updated Oct. 30, 2012, 7:56 a.m.)
Review request for Solid.
Changes
-------
Move battery charge percent notification handling into its own function so we
cann call it whenever we feel like it without needing to fuzz around in the
signals/slots.
Only problem we now have is that the battery low notification gets emitted way
before the workspace is up resulting in a similar ugly notification like the
"Profile error" thing. The checkBattery() function is invoked delayed by 30
seconds but how can I make it only delay it only when starting the session? The
notifiation is triggered from batteryAdded slot, which seems to be invoked
quite early in the process. So I cannot just add a timer, otherwise, if a
battery gets added, the user will get the notification that the new battery is
low much later.
Description
-------
When starting the system while the battery is already below the
warning/critical battery level threshold, there will be no notification about
that.
This patch fixes this by introducing a m_batteriesPercentNotified bool that is
false on startup and if it is false, the battery low notification will be
triggered if the battery is lower or becomes lower than the threshold no matter
if it already has been lower.
This addresses bug 298604.
http://bugs.kde.org/show_bug.cgi?id=298604
Diffs (updated)
-----
powerdevil/daemon/powerdevilcore.h 7140051
powerdevil/daemon/powerdevilcore.cpp 3c40780
Diff: http://git.reviewboard.kde.org/r/107117/diff/
Testing
-------
Set my low battery level to 90% and started the system. Once the desktop was up
I got the notification that my battery was low.
I don't know if it is good to also start the suspend timer right when the
desktop comes up, though.
Thanks,
Kai Uwe Broulik
_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
