----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106794/#review21306 -----------------------------------------------------------
This review has been submitted with commit 0692107bdff3788a3fe6b6eb98dccde1db733b30 by Oliver Henshaw to branch push/4.9. - Commit Hook On Oct. 12, 2012, 5:45 p.m., Oliver Henshaw wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106794/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2012, 5:45 p.m.) > > > Review request for Solid. > > > Description > ------- > > Prevent button action from enabling disabled DPMS > > Button actions call triggerImpl, which leaves DPMS enabled. It can't be > disabled until return from idle, as that would wake the screen. Solve > this by explicitly setting DPMS timeouts to zero when DPMS is meant to > be disabled - i.e. when unloading the action or when screen power > management is inhibited. > > CCBUG: 295164 > > > Diffs > ----- > > powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp > a16bf7ee254b9a40c6f033c93e5ca63226469e6e > > Diff: http://git.reviewboard.kde.org/r/106794/diff/ > > > Testing > ------- > > (in combination with review request #106793 ) > > Set power button to "Turn off screen" then press it, wait for the screen to > turn off then wake the system from idle. Check 'xset -q' has expected values > in various situations, e.g.: > > - when timed screen power saving is enabled > - when it's disabled > - when it hasn't been enabled in this login > - when screen power saving is inhibited > - when profile or configuration or activity change > - when profile or configuration or activity change when screen power saving > is inhibited > > I think this covers all cases, but please hammer away with it and see if you > can find any problems I've missed. > > > Thanks, > > Oliver Henshaw > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel