----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107503/#review22725 -----------------------------------------------------------
This review has been submitted with commit bbe593dbb6fb954c718c268d8a6cc31d8fbedd6f by Kai Uwe Broulik to branch master. - Commit Hook On Nov. 28, 2012, 2:14 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107503/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2012, 2:14 p.m.) > > > Review request for Solid and Oliver Henshaw. > > > Description > ------- > > I found out that the Powerdevilprofilegenerator which is fired on first start > of a KDE session which generates the profile and sets the defaults adds the > DPMS action no matter if it is compiled or supported. That patch makes it > only add it when it is compiled (HAVE_DPMS) and the action returns > isSupported(). This will silence the most prominend warning about missing > DPMS and having something in the config file which doesn't work is not good. > Combined with the patch by Oliver Henshaw this will make PowerDevil not stick > in your face on startup anymore (except for that Battery Low stuff I added :D > which I am thinking of a fix) > > > Diffs > ----- > > powerdevil/daemon/powerdevilprofilegenerator.cpp 4cdbe11 > > Diff: http://git.reviewboard.kde.org/r/107503/diff/ > > > Testing > ------- > > Deleted my powermanagementrc, Tested *without* DPMS, works flawlessly. Cannot > test with since I do not have DPMS support. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
