----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108394/#review25406 -----------------------------------------------------------
src/config.h <http://git.reviewboard.kde.org/r/108394/#comment19436> Make it a const method please src/config.cpp <http://git.reviewboard.kde.org/r/108394/#comment19437> You can just "return output" from here. This way you can also completely drop the 'result' variable. - Dan Vrátil On Jan. 13, 2013, 8:31 p.m., Jeremy Paul Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108394/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2013, 8:31 p.m.) > > > Review request for Solid and Àlex Fiestas. > > > Description > ------- > > This just adds a simple helper method to easily get the primary output. > > > Diffs > ----- > > src/config.h 470bef848fe8a25debd7a900646a96481c608bcc > src/config.cpp d98f123d69e8f5ed4211ec789937ee5a1bf3e4ea > > Diff: http://git.reviewboard.kde.org/r/108394/diff/ > > > Testing > ------- > > It works fine here in my orientation dataengine code. > > > Thanks, > > Jeremy Paul Whiting > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel