-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108415/
-----------------------------------------------------------

(Updated Jan. 14, 2013, noon)


Review request for Solid, Àlex Fiestas and Dan Vrátil.


Description (updated)
-------

Since the enumeration for rotation in libkscreen was backwards between right 
and left the order for rotating in the kcm was also backwards (Counter 
clockwise was going normal -> right -> inverted -> left, which was wrong, but 
right because the enumeration was backwards also).  This fixes the order so the 
enumeration can also be fixed at the same time.

Also, note xrandr rotation angles are counter clockwise, while qml rotations 
are clockwise.


Diffs
-----

  kcm/qml/Output.qml 0fb3cec701b8ded7e11f1e57a02b82fa48c0d579 
  kcm/qml/OutputControls.qml fb743ad15a28862d6ff41bd09a6c51049e473e16 

Diff: http://git.reviewboard.kde.org/r/108415/diff/


Testing
-------

It works fine here.  Also tested it was working fine before with the old 
enumeration values, but once those were fixed this was backwards.


Thanks,

Jeremy Paul Whiting

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to