> On Jan. 17, 2013, 1:03 a.m., Dario Freddi wrote: > > After a second look, there's a whole load of synchronous things in the > > backend init, hence I'd waive the .waitForFinished() version to be merged, > > with a huge note to self to revise that whole init routine for 4.11 > > (already on it). Thanks for such an amazing job and your patience. > > > > P.S.: Just to be fully clear, please merge the last rev without the > > QDBusPendingCallWatcher, as that other patch wouldn't work. > > Lukáš Tinkl wrote: > I'm considering waiting with the merge after KDE 4.10 gets released, we > have to test it in F18 a bit more and find out ways to fix the "resuming" > signal > > Lukáš Tinkl wrote: > Oh and a bug in kernel breaks hibernation as well :) > https://bugzilla.redhat.com/show_bug.cgi?id=896243 > > Dario Freddi wrote: > Wonderful :) This makes my "ship it" void I guess :P
The patch is not applying, I wanted to try it... If you need more testing before merging, ping me. :) Cheers! - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108407/#review25705 ----------------------------------------------------------- On Jan. 14, 2013, 2:24 p.m., Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108407/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 2:24 p.m.) > > > Review request for Solid and Dario Freddi. > > > Description > ------- > > This patch adds support for systemd-login1 service to Powerdevil's upower > backend. The main purpose is that UPower will be soon dropping support[1] for > suspend/resume features so we have to rely on systemd. With this login1, we > are also gaining support for HybridSleep, where implemented by the system. > > One caveat: the current login1 implementation doesn't support[2] emitting the > "resume from suspend" signal > > [1] > http://lists.freedesktop.org/archives/devkit-devel/2013-January/001339.html > [2] http://www.freedesktop.org/wiki/Software/systemd/inhibit > > > This addresses bug https://bugzilla.redhat.com/show_bug.cgi?id=859227. > > http://bugs.kde.org/show_bug.cgi?id=https://bugzilla.redhat.com/show_bug.cgi?id=859227 > > > Diffs > ----- > > powerdevil/daemon/BackendConfig.cmake 5dbe6f6 > powerdevil/daemon/backends/upower/login1suspendjob.h PRE-CREATION > powerdevil/daemon/backends/upower/login1suspendjob.cpp PRE-CREATION > powerdevil/daemon/backends/upower/powerdevilupowerbackend.h ba942bd > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 97a409b > powerdevil/daemon/backends/upower/upowersuspendjob.h bbe2f45 > powerdevil/daemon/backends/upower/upowersuspendjob.cpp fa64ab0 > > Diff: http://git.reviewboard.kde.org/r/108407/diff/ > > > Testing > ------- > > > Thanks, > > Lukáš Tinkl > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel