----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/#review30994 -----------------------------------------------------------
Just a note that I think that dimming to an absolute brightness is indeed the right approach. I can't speak to the original intent of the code, but I think the relative dimming on the way from the original brightness to zero is just to ensure good intermediate values during the transition to the final brightness. Now the the final brightness is non-zero we need to make sure we never brighten, of course. But this is taken care of. If we were to re-introduce a multi-stage dimming we should again pick an appropriate point between the original brightness and the final brightness. - Oliver Henshaw On April 13, 2013, noon, Danny Baumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109792/ > ----------------------------------------------------------- > > (Updated April 13, 2013, noon) > > > Review request for kde-workspace, Solid, Dario Freddi, and Oliver Henshaw. > > > Description > ------- > > This change does two things: > - No longer dim display before the dim time set by the user elapses. > This fixes bug #304696 > - No longer assume that 0% display brightness produces a visible result. > This doesn't work with the intel-backlight backlight interface (as it > turns off the backlight at 0% brightness). According to the kernel > developers (see [1] and [2]), this isn't a safe assumption to make for > other backlight interfaces either. Instead of always dimming to 0%, > make the amount of dimming configurable. > > [1] > http://lists.freedesktop.org/archives/intel-gfx/2013-March/026152.html > [2] > http://lists.freedesktop.org/archives/intel-gfx/2013-March/026140.html > > > This addresses bug 304696. > http://bugs.kde.org/show_bug.cgi?id=304696 > > > Diffs > ----- > > powerdevil/daemon/actions/bundled/dimdisplay.cpp > 11554e3ba5d2f67d4d1de9d61c744c6c40a32d27 > > Diff: http://git.reviewboard.kde.org/r/109792/diff/ > > > Testing > ------- > > > Thanks, > > Danny Baumann > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
