----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110135/#review31464 -----------------------------------------------------------
The patch is ok, but the changes to the service name are wrong. It should still stay org.freedesktop.PowerManagement. This is not to be confused with the comments to the previous patch, where basic actions could be found on the fd.o PowerManagement service - this signal should instead come from Solid's service, and as I said it should actually be a signal in the PowerManagement::Notifier class in libsolid. I'll see if I can include that in 4.11. kcontrol/randr/module/randrmonitor.cpp <http://git.reviewboard.kde.org/r/110135/#comment23443> Indeed the service should remain the same (org.kde.Solid.PowerManagement). Note to self: we should add an API for this to libsolid. ksmserver/shutdowndlg.cpp <http://git.reviewboard.kde.org/r/110135/#comment23444> Same here, the service should be the same as before - Dario Freddi On April 23, 2013, 7:12 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110135/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 7:12 p.m.) > > > Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler. > > > Description > ------- > > Suspend/hibernate are now longer are part of > org.kde.Solid.PowerManagement interface, so adjusting to new one. > > > This addresses bug 318737. > http://bugs.kde.org/show_bug.cgi?id=318737 > > > Diffs > ----- > > kcontrol/randr/module/randrmonitor.cpp 5a719a4 > ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 > ksmserver/shutdowndlg.cpp 247c877 > plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 > plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 > plasma/generic/dataengines/time/timeengine.cpp 2f69e8f > plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d > > Diff: http://git.reviewboard.kde.org/r/110135/diff/ > > > Testing > ------- > > Compiled, actions work now. > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
