----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110026/#review32698 -----------------------------------------------------------
Ship it! Ship It! - Dario Freddi On April 15, 2013, 3:19 p.m., Oliver Henshaw wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110026/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 3:19 p.m.) > > > Review request for Solid. > > > Description > ------- > > Stop searching for timeout once identifier found > > The identifier is unique. > > Use QList::contains() rather than a nested for loop; break from the > QHash loop once the search succeeds. > > Continuing to loop over the action timeouts should be safe but the > brightness action may use KAuth which may return to the event loop; this > allows another event to e.g. call loadProfile() which reloads all > actions and kick over the timeouts. > > CCBUG: 315379 > > > Diffs > ----- > > powerdevil/daemon/powerdevilcore.cpp > 2dcdbc62236d5c1fae384fdb9111825a2ebf5204 > > Diff: http://git.reviewboard.kde.org/r/110026/diff/ > > > Testing > ------- > > Checked the correct actions still fire on the correct timeouts. Checked > actions that register several timeouts and actions that register just one. > > > Thanks, > > Oliver Henshaw > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
