> On July 26, 2013, 2:07 a.m., Kurt Hindenburg wrote: > > I think this commit is causing build failures on MacOSX - kdelibs/4.11 > > branch > > > > [ 21%] Building CXX object > > solid/solid/CMakeFiles/solid.dir/backends/iokit/iokitdevice.o > > > > /Volumes/Projects/kde/src/kde/kdelibs/solid/solid/backends/iokit/iokitdevice.cpp:235:25: > > error: > > allocating an object of abstract class type > > 'Solid::Backends::IOKit::Battery' > > iface = new Battery(this); > > ^ > > /Volumes/Projects/kde/src/kde/kdelibs/solid/solid/ifaces/battery.h:78:21: > > note: > > unimplemented pure virtual method 'capacity' in 'Battery' > > virtual int capacity() const = 0; > > ^ > > /Volumes/Projects/kde/src/kde/kdelibs/solid/solid/ifaces/battery.h:93:22: > > note: > > unimplemented pure virtual method 'isPowerSupply' in 'Battery' > > virtual bool isPowerSupply() const = 0; > > ^ > > /Volumes/Projects/kde/src/kde/kdelibs/solid/solid/ifaces/battery.h:122:22: > > note: > > unimplemented pure virtual method 'capacityChanged' in 'Battery' > > virtual void capacityChanged(int value, const QString &udi) = 0; > > ^ > > /Volumes/Projects/kde/src/kde/kdelibs/solid/solid/ifaces/battery.h:152:22: > > note: > > unimplemented pure virtual method 'powerSupplyStateChanged' in > > 'Battery' > > virtual void powerSupplyStateChanged(bool newState, const... > > ^ > > /Volumes/Projects/kde/src/kde/kdelibs/solid/solid/backends/iokit/iokitdevice.cpp:216:13: > > warning: > > 18 enumeration values not handled in switch: 'Unknown', 'Block', > > 'StorageAccess'... [-Wswitch] > > switch (type) > > ^ > > 1 warning and 1 error generated. > > make[2]: *** > > [solid/solid/CMakeFiles/solid.dir/backends/iokit/iokitdevice.o] Error 1
I wasn't aware there was another backend. Can you point me to some docs on IOKit? Will look into this, sorry for the inconvenience. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110384/#review36517 ----------------------------------------------------------- On May 13, 2013, 3:38 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110384/ > ----------------------------------------------------------- > > (Updated May 13, 2013, 3:38 p.m.) > > > Review request for Solid. > > > Description > ------- > > This patch adds support for the "power supply" property in UPower batteries > that tells if a battery is actually powering the machine (ie. laptop battery) > or just inside a peripheral device (ie. mouse, keyboard, ..) > > In the UDev backend it reads the power supply property, in HAL, which doesn't > support this, we're assuming that primary battery and UPS battery are power > supply and others are not (which is the current way PowerDevil for example > determins whether a computer has a battery or not). Can be somewhat > problematic as not all mice report themselves as mouse battery. > > This patch will in the end allow for example Plasma's battery monitor to only > average battery percentage of batteries that are actually powering the > machine, or PowerDevil to emit a separate message when your mouse battery > goes low. > > > Diffs > ----- > > solid/solid/backends/fakehw/fakebattery.h c7e2791 > solid/solid/backends/fakehw/fakebattery.cpp 0afe765 > solid/solid/backends/fakehw/fakecomputer.xml fe7e323 > solid/solid/backends/hal/halbattery.h e2f38a0 > solid/solid/backends/hal/halbattery.cpp 4c530da > solid/solid/backends/upower/upowerbattery.h 9d52f7b > solid/solid/backends/upower/upowerbattery.cpp 1a40a2a > solid/solid/backends/upower/upowerdevice.cpp 4930053 > solid/solid/battery.h 3afac6f > solid/solid/battery.cpp 37d7321 > solid/solid/ifaces/battery.h 9987d18 > > Diff: http://git.reviewboard.kde.org/r/110384/diff/ > > > Testing > ------- > > After adjusting Plasma's powermanagement dataengine and battery monitor, I > had it show two batteries (laptop battery and bluetooth mouse) and only take > the laptop battery for battery percentage. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
