----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117882/#review56912 -----------------------------------------------------------
backends/xrandr/xrandr.cpp <https://git.reviewboard.kde.org/r/117882/#comment39678> Could you move this into the new if () below (and add else branch of course)? backends/xrandr/xrandrconfig.h <https://git.reviewboard.kde.org/r/117882/#comment39679> Private maybe? backends/xrandr/xrandrconfig.cpp <https://git.reviewboard.kde.org/r/117882/#comment39681> Initialize m_primaryOutput to some invalid output ID (0, -1?) backends/xrandr/xrandrconfig.cpp <https://git.reviewboard.kde.org/r/117882/#comment39680> Same as above, move to the if() statement please backends/xrandr/xrandrconfig.cpp <https://git.reviewboard.kde.org/r/117882/#comment39682> What if primary is unset from all outputs? m_primaryOutput won't get updated then (reset to invalid value) backends/xrandr/xrandrconfig.cpp <https://git.reviewboard.kde.org/r/117882/#comment39683> && m_primaryOutput != -1 ? - Dan Vrátil On April 29, 2014, 5:59 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117882/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 5:59 p.m.) > > > Review request for Solid. > > > Repository: libkscreen > > > Description > ------- > > Adds a new signal called Config::primaryOutputChanged, specially useful for > apps that need to track the primary output (like plasma, or any presentation > app) > > > Diffs > ----- > > backends/xrandr/xrandr.cpp e3cb2b6 > backends/xrandr/xrandrconfig.h daa1bbd > backends/xrandr/xrandrconfig.cpp d4338bb > src/config.h 84fd955 > src/config.cpp 6c0898c > > Diff: https://git.reviewboard.kde.org/r/117882/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel