> On April 30, 2014, 2:57 p.m., Àlex Fiestas wrote: > > It compiles so I guess it is good to go! > > > > Would be nice to make libbluedevil a framework > > (http://community.kde.org/Frameworks/CreationGuidelines) but that can > > happen in another review. > > > > Godd job!
Oh btw push this in a branch called frameworks. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117840/#review56993 ----------------------------------------------------------- On April 28, 2014, 2:18 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117840/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 2:18 p.m.) > > > Review request for Bluedevil and Àlex Fiestas. > > > Repository: libbluedevil > > > Description > ------- > > This is a port of libbluedevil to Qt5. > > > Diffs > ----- > > CMakeLists.txt 5509d61 > bluedevil/CMakeLists.txt d3ac5fd > bluedevil/bluedeviladapter.cpp 668934a > bluedevil/bluedevildevice.cpp 884d015 > bluedevil/bluedevilmanager.cpp e5848be > bluedevil/bluedevilmanager_p.cpp ad32470 > bluedevil/test/CMakeLists.txt 8f12785 > > Diff: https://git.reviewboard.kde.org/r/117840/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel