----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117943/#review57304 -----------------------------------------------------------
This review has been submitted with commit 1d5f8c27a1e7fda4e2a913d7a02bc7b9af7fbc2f by David Rosca to branch frameworks. - Commit Hook On May 2, 2014, 1:45 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117943/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 1:45 p.m.) > > > Review request for Bluedevil and Àlex Fiestas. > > > Repository: bluedevil > > > Description > ------- > > This patch removes all usage of KDELibs4Support in sendfile (src/sendfile). > All string literals are also wrapped in QLatin1String/QStringLiteral. > > Use QCommandLineParser instead of KCmdArgs. It does not support --license and > --author options now. > > There is one issue with native file dialog, QFileDialog::ExistingFiles mode > (eg. select multiple files) doesn't work - it still allows to select only one > file. > It works fine with QFileDialog::DontUseNativeDialog option set to true. > > > Diffs > ----- > > src/sendfile/CMakeLists.txt c5309ba > src/sendfile/debug_p.h PRE-CREATION > src/sendfile/debug_p.cpp PRE-CREATION > src/sendfile/discoverwidget.cpp f16abee > src/sendfile/main.cpp 79a78e8 > src/sendfile/pages/selectdeviceandfilespage.h ceb0674 > src/sendfile/pages/selectdeviceandfilespage.cpp e63806a > src/sendfile/pages/selectdevicepage.cpp 142302a > src/sendfile/pages/selectfilediscover.ui b85e85c > src/sendfile/pages/selectfilespage.cpp 423b772 > src/sendfile/sendfilesjob.h e230a4a > src/sendfile/sendfilesjob.cpp 339c3a5 > src/sendfile/sendfilewizard.cpp 87d156f > > Diff: https://git.reviewboard.kde.org/r/117943/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
