----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117939/#review57305 -----------------------------------------------------------
This review has been submitted with commit 1fa881a5d6eab40c04e40f35fe7c295b8d6f77bb by David Rosca to branch frameworks. - Commit Hook On May 2, 2014, 1:45 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117939/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 1:45 p.m.) > > > Review request for Bluedevil and Àlex Fiestas. > > > Repository: bluedevil > > > Description > ------- > > This patch removes all usage of KDELibs4Support in monolithic > (src/monolithic). > All string literals are also wrapped in QLatin1String/QStringLiteral. > Removed unused m_interfaceMap and EntryInfo struct. > > Use QMenu::addSection instead of KMenu::addTitle. > Use QCommandLineParser instead of KCmdArgs. It does not support --license and > --author options now. > > > Diffs > ----- > > src/monolithic/CMakeLists.txt 5822e27 > src/monolithic/main.cpp 312d8de > src/monolithic/monolithic.h 2d6790a > src/monolithic/monolithic.cpp 980531a > > Diff: https://git.reviewboard.kde.org/r/117939/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel