----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120879/#review69383 -----------------------------------------------------------
Ship it! Ship It! - Lamarque Souza On Oct. 29, 2014, 4:27 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120879/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 4:27 a.m.) > > > Review request for Solid. > > > Repository: plasma-nm > > > Description > ------- > > In some translation, for example, Chinese, quite a lot of tranlated country > name are length-2 string, which make provider list empty in those case. > > Check the country name existence in m_Countries IMHO is better. > > > Diffs > ----- > > libs/editor/mobileproviders.cpp df1f7ad > > Diff: https://git.reviewboard.kde.org/r/120879/diff/ > > > Testing > ------- > > using zh_CN and select China, provider name listed. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel