----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121693/#review72549 -----------------------------------------------------------
daemon/powerdevilcore.cpp <https://git.reviewboard.kde.org/r/121693/#comment50583> Qt 5.4 would allow us to use a lambda instead - Kai Uwe Broulik On Dez. 27, 2014, 12:53 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121693/ > ----------------------------------------------------------- > > (Updated Dez. 27, 2014, 12:53 nachm.) > > > Review request for Solid. > > > Repository: powerdevil > > > Description > ------- > > This patch makes PowerDevil postpone its notifications (battery broken, > battery low) until the notification service has been registered to avoid ugly > oldschool notifications from appearing ontop of KSplash. > > The notifications are emitted when: > - The notification service is already registered (kded restart) > - The service becomes available (plasma startup) > - After 30 seconds (to ensure the notifications are shown) > > This makes the "your battery is broken" and "battery low" notifications > appear right after Plasma is started on login whereas the former previously > had a 30s hardcoded delay whereas the latter appeared right on ksplash > > > Diffs > ----- > > daemon/powerdevilcore.h a27e2ba > daemon/powerdevilcore.cpp 05ee2e6 > > Diff: https://git.reviewboard.kde.org/r/121693/diff/ > > > Testing > ------- > > Logged in and out, notifications fire. Restarted kded while plasma was > running (emit right away), while it was not running (30s timeout), and > started plasma shortly after kded (emit once service is there). Works fine, > looks much sleeker now, and notifications also only seem to be fired once > regardless of when they have been for the first time. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
