-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121798/
-----------------------------------------------------------
(Updated Jan. 5, 2015, 9:27 vorm.)
Review request for Solid, Àlex Fiestas and Martin Gräßlin.
Changes
-------
Address Martin's comments
- Class is now named KWinKScreenHelperEffect
- Simplifications in the native event filter
- Also cleaned up some includes
Bugs: 340063
https://bugs.kde.org/show_bug.cgi?id=340063
Repository: powerdevil
Description
-------
This is an implementation of the client side of the KScreen effect for
PowerDevil eventually allowing it to fade the screen before going to sleep. The
code is loosely based on Alex' initial work [1] but ported to XCB.
[1]
http://quickgit.kde.org/?p=libkscreen.git&a=commit&h=70cf4482ed2e83d14c2ec9b805921ba4eb741082
Diffs (updated)
-----
daemon/kwinkscreenhelpereffect.h PRE-CREATION
daemon/CMakeLists.txt f26f786
daemon/config-powerdevil.h.cmake b730cd9
daemon/kwinkscreenhelpereffect.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121798/diff/
Testing
-------
Calling start() causes the scren to dim, the state is properly updated by KWin
and the respective signals are fired.
As for the implementation in the suspendsession action I have to agree with
Martin here that we should drop the support for locking on non-logind platforms
since it makes the code utterly complex and isn't secure anyway. That way
PowerDevil could just kick off the fade effect, wait for it to be done and then
tell Logind to suspend which completely takes care of the locking (and more
importantly the waiting for the lock to be established *before* powering down).
Thanks,
Kai Uwe Broulik
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
