-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122130/#review74280
-----------------------------------------------------------



daemon/powerdevilpolicyagent.cpp
<https://git.reviewboard.kde.org/r/122130/#comment51568>

    Isn't it the same as m_cookieToAppName.values()?


- Emmanuel Pescosta


On Jan. 18, 2015, 10:06 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122130/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2015, 10:06 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This adds a new "ListInhibitions" method and "InhibitionsChanged" signal to 
> the org.kde.Solid.PowerManagement.PolicyAgent allowing others to know who has 
> posted an inhibition.
> 
> Due to the complexity of DBus marshalling I chose to use a flat QStringList 
> for it with the even indices being the application name and the odd ones the 
> respective reason. It does not do any formatting (getting proper app names) 
> or duplicate removal.
> 
> 
> Diffs
> -----
> 
>   daemon/kdedpowerdevil.h 137e6ca 
>   daemon/kdedpowerdevil.cpp 4228741 
>   daemon/org.kde.Solid.PowerManagement.PolicyAgent.xml a07dd73 
>   daemon/powerdevilpolicyagent.h 08a3b54 
>   daemon/powerdevilpolicyagent.cpp 7c7348d 
> 
> Diff: https://git.reviewboard.kde.org/r/122130/diff/
> 
> 
> Testing
> -------
> 
> Works, I can list the inhibitions using
> qdbus --literal org.kde.Solid.PowerManagement 
> /org/kde/Solid/PowerManagement/PolicyAgent 
> org.kde.Solid.PowerManagement.PolicyAgent.ListInhibitions
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to