----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121386/#review74371 -----------------------------------------------------------
daemon/backends/upower/xrandrbrightness.cpp <https://git.reviewboard.kde.org/r/121386/#comment51599> do not use get_screen_resources: it blocks, see https://bugreports.qt.io/browse/QTBUG-40207 and https://bugs.kde.org/show_bug.cgi?id=329979#c17 - Martin Gräßlin On Jan. 19, 2015, 10:30 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121386/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 10:30 p.m.) > > > Review request for Solid and Martin Gräßlin. > > > Repository: powerdevil > > > Description > ------- > > This ports the XRandrBacklight class to XCB. > > The code is adapted from xbacklight, drops the legacy backlight stuff, > whatever that is. > > It still uses XSync since xcb_aux_sync yields a linker error here (what did I > overlook?). Pretty ugly C stuff (fre...), suggestions on how to improve the > code look (nullptr, C++ style casts, etc) welcome. > > > Diffs > ----- > > daemon/backends/upower/xrandrbrightness.h 873b1f5 > daemon/backends/upower/xrandrbrightness.cpp 8e5617d > > Diff: https://git.reviewboard.kde.org/r/121386/diff/ > > > Testing > ------- > > My hopes were that it would give us a more precise backlight handling but I > get a range of 0..10 nonetheless. Other than that seems to work exactly like > it did before. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
