----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122316/#review75003 -----------------------------------------------------------
daemon/backends/upower/powerdevilupowerbackend.cpp <https://git.reviewboard.kde.org/r/122316/#comment51935> I'd rather we killed this too; maybe moving it to init. Otherwise we still have that re-entrant risk that causes everything to maul the CPU like in the bug report. daemon/backends/upower/powerdevilupowerbackend.cpp <https://git.reviewboard.kde.org/r/122316/#comment51934> you don't need this line. after this else we set success to true then exit. Keeps code flow consistent to not sometimes set an RC sometimes exit - David Edmundson On Jan. 29, 2015, 8:05 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122316/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 8:05 p.m.) > > > Review request for Solid and David Edmundson. > > > Bugs: 337674 > https://bugs.kde.org/show_bug.cgi?id=337674 > > > Repository: powerdevil > > > Description > ------- > > - Query maximum value once and then just return the stored value, it's not > like PowerDevil could really cope with it changing anyway > - Query brightness value once and then just update it when udevqt tells us to > - Don't care for the result when setting the brightness, just call it async > > *adds refactoring this to be as async as possible to the 5.3 todo* > > > Diffs > ----- > > daemon/backends/upower/powerdevilupowerbackend.h 220289c > daemon/backends/upower/powerdevilupowerbackend.cpp 51a052a > > Diff: https://git.reviewboard.kde.org/r/122316/diff/ > > > Testing > ------- > > I'm running on the helper now but I was never able to reproduce the problem. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel