> On Dez. 8, 2014, 2:15 nachm., Sebastian Kügler wrote: > > solid-device-automounter/kcm/DeviceAutomounterKCM.ui, line 45 > > <https://git.reviewboard.kde.org/r/121361/diff/1/?file=331961#file331961line45> > > > > Well, with this change, the whatsthis and I suppose the function of > > this checkbox does the exact opposite of its name. > > > > automountUnknownDevices now means "only automount know devices". > > Thomas Lübking wrote: > "automountUnknownDevices" is now labeled "Automatically mount unknown > devices" and hinted "all attached devices will be automatically mounted[, > "otherwise only remembered devices will be"] > > > > Sounds correct to me, but the automount GUI sucks. > > You've to enable automounting to get a list of four items: > - known only > - "all" (does that invoke the "known only" rule?) on login > - on plugin > - an override list > > What you indeed have is "on plugin" and "on login", multiplied by the > "seen only" rule. > And then there's an override list, with a lot of unchecked devices what > seems to suggest the above rules doesn't actually apply to most things. > > What there should be are two checkboxes: > [ ] Automount removable media when attached > [ ] Automount removable media when logging in > > each of them activating a "Device override" group which allows to > controlthe override list as well as a third checkbox > > [ ] Do not automount media that has not been mounted before > > And the following override list probably needs to be some sort of > tristate - defaulting to no override, what could be done by a leading > checkbox column which activates the override for this device itfp. > > Christoph Feck wrote: > Frank, are you able to propose an updated patch with the above comments > addressed? > > Frank Schütte wrote: > What you suggest seems right to me. Your naming is fine with me. Does "is > now labeled" mean, this string is fixed and already in the code, so my patch > is useless and I should close this review request ? > > For the rest I am not able to modify the GUI. > Can I find out, in what version the corrected strings will appear?
Christoph, sorry I am not able to propose an updated patch. I was just able to fix the strings. - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121361/#review71555 ----------------------------------------------------------- On Dez. 5, 2014, 7:06 nachm., Frank Schütte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121361/ > ----------------------------------------------------------- > > (Updated Dez. 5, 2014, 7:06 nachm.) > > > Review request for kdelibs, Solid, Christoph Feck, and Helio Castro. > > > Bugs: 243046 and 261376 > http://bugs.kde.org/show_bug.cgi?id=243046 > http://bugs.kde.org/show_bug.cgi?id=261376 > > > Repository: kde-runtime > > > Description > ------- > > automounterrc has four settings: > [General] > AutomountEnabled=true > AutomountOnLogin=false > AutomountOnPlugin=false > AutomountUnknownDevices=true > > The ui text for AutomountUnknownDevices says the opposite of its > functionality. This is repaired by the patch. Login/Plugin enable/disable > overrides. I tried to clarify this a little bit. > > > Diffs > ----- > > solid-device-automounter/kcm/DeviceAutomounterKCM.ui 3827e95 > > Diff: https://git.reviewboard.kde.org/r/121361/diff/ > > > Testing > ------- > > > Thanks, > > Frank Schütte > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
