> On April 7, 2015, 10:44 a.m., Àlex Fiestas wrote: > > daemon/backends/upower/ddchelper.cpp, line 29 > > <https://git.reviewboard.kde.org/r/123262/diff/2/?file=360145#file360145line29> > > > > Calling init in the constructor is dangeours since it is performing > > lots of complex operations that are far from initializing the object state.
My suggestion to solve this issue: make init() a slot and call QTimer::singleShot(0, this, &DccHelper::init) from here. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123262/#review78609 ----------------------------------------------------------- On April 5, 2015, 5:31 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123262/ > ----------------------------------------------------------- > > (Updated April 5, 2015, 5:31 p.m.) > > > Review request for Solid. > > > Repository: powerdevil > > > Description > ------- > > This allows PowerDevil to use the ddccontrol utility to manipulate brightness > of external monitors through Display Data Channel. > > It becomes the last link in the fallback chain; it first tries XRandR, then > it tries the sysfs helper, and if all that fails it tries to use the > ddccontrol utility. > > dcccontrol unfortunately doesn't have machine-readable output so I have to > take apart its probing output to get the device name and id of the backlight > controls. Also it is pretty slow both initializing (kded startup, the helper > saves the values and writes directly to the address returned by the initial > probing) and setting brightness (that one doesn't block but it can take > seconds until your monitor actually changes brightness) > > > Diffs > ----- > > daemon/BackendConfig.cmake 295a8a2 > daemon/backends/upower/ddc_helper_actions.actions PRE-CREATION > daemon/backends/upower/ddchelper.h PRE-CREATION > daemon/backends/upower/ddchelper.cpp PRE-CREATION > daemon/backends/upower/powerdevilupowerbackend.h 1c4dd59 > daemon/backends/upower/powerdevilupowerbackend.cpp 87b9cc7 > > Diff: https://git.reviewboard.kde.org/r/123262/diff/ > > > Testing > ------- > > It's working pretty nicely, I can adjust brightness of my desktop monitor > through battery monitor and have it automatically dimmed after a timeout. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
