-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124388/#review82731
-----------------------------------------------------------


Thanks!


daemon/backends/upower/powerdevilupowerbackend.cpp (line 141)
<https://git.reviewboard.kde.org/r/124388/#comment57051>

    if (!m_login1Interface …)


- Kai Uwe Broulik


On Juli 20, 2015, 2:04 nachm., Eric Koegel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124388/
> -----------------------------------------------------------
> 
> (Updated Juli 20, 2015, 2:04 nachm.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Internally, it uses the login1 interface with ConsoleKit2 since they share 
> identical DBUS calls. It also changes the setupSystemdInhibition to 
> setupSeatManagerInhibition so that the login1 and ConsoleKit2 inhibit calls 
> to minimize code duplication.
> 
> This patch doesn't modify the build system to keep it small. A future patch 
> can be added to use ConsoleKit2 on BSD systems as well.
> 
> ConsoleKit2's suspend/hibernate/inhibit DBUS API is documented at: 
> http://consolekit2.github.io/ConsoleKit2/#Manager
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/powerdevilupowerbackend.h 3752977 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 5120d3e 
>   daemon/powerdevilpolicyagent.h ef41ad7 
>   daemon/powerdevilpolicyagent.cpp 9210a06 
> 
> Diff: https://git.reviewboard.kde.org/r/124388/diff/
> 
> 
> Testing
> -------
> 
> Built powerdevil with patch and pkla files on a Gentoo system with OpenRC. 
> Before patch there was no suspend option, after there was and clicking it 
> resulted in the system properly suspending.
> 
> 
> Thanks,
> 
> Eric Koegel
> 
>

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to