----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124730/#review84114 -----------------------------------------------------------
Ship it! I think you the first major changelog entry for 5.5, congratulations - David Edmundson On Aug. 20, 2015, 6:32 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124730/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 6:32 p.m.) > > > Review request for Plasma, Solid and Torrie Fischer. > > > Bugs: 351003 > https://bugs.kde.org/show_bug.cgi?id=351003 > > > Repository: plasma-desktop > > > Description > ------- > > This is a straight port of the solid-device-automounter from kde-runtime that > was somehow lost to plasma-desktop. I didn't do git graft magic (can this be > done later? ie. import kde-runtime folder here to there and then apply a diff > on top?). > > > Diffs > ----- > > CMakeLists.txt 4717780 > solid-device-automounter/CMakeLists.txt PRE-CREATION > solid-device-automounter/COPYING PRE-CREATION > solid-device-automounter/SETTINGS PRE-CREATION > solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION > solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION > solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION > solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION > solid-device-automounter/kcm/DeviceModel.h PRE-CREATION > solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION > solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION > solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION > solid-device-automounter/kcm/Messages.sh PRE-CREATION > solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION > solid-device-automounter/kded/CMakeLists.txt PRE-CREATION > solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION > solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION > solid-device-automounter/kded/device_automounter.desktop PRE-CREATION > solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION > solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION > solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION > solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124730/diff/ > > > Testing > ------- > > Seems to work, translations are probably broken. > Told it to auto mount all the things, did that. Told it to mount just one > thing automatically, did that. Somehow the list of non-attached devices grows > even when I re-attach the same device. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
