----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125156/ -----------------------------------------------------------
Review request for Solid and Kai Uwe Broulik. Bugs: 350676 https://bugs.kde.org/show_bug.cgi?id=350676 Repository: powerdevil Description ------- As described in https://bugs.kde.org/show_bug.cgi?id=350676#c5 There are two issue here: 1. m_cacheBrightness may not be updated after animation. 2. setStartValue and setEndValue may emit unwanted valueChanged even when animation is stopped. Though I don't agree that the bug is in Qt (see my https://bugs.kde.org/show_bug.cgi?id=350676#c7). But we need to skip this emit anyway. 1 is resolved by always query the brightness when animation emit finished(). slotScreenBrightnessChanged is reused for this purpose. 2 is resolved by disconnect and reconnect the signal to skip setStartValue and setEndValue. Diffs ----- daemon/backends/upower/powerdevilupowerbackend.cpp 3262c35 Diff: https://git.reviewboard.kde.org/r/125156/diff/ Testing ------- not be able to reproduce 350676. Thanks, Xuetian Weng
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel