> On Gru 14, 2015, 3:01 po południu, David Rosca wrote: > > autotests/fakebluez/deviceinterface.cpp, line 30 > > <https://git.reviewboard.kde.org/r/126342/diff/2/?file=422116#file422116line30> > > > > This is still non-POD static. If it fixes issue in clazy, then it is > > bug in clazy. > > > > You can try static const char * = "..." if it works, otherwise leave it > > as it is.
Changeing to char * brakes it (errors in compilation). Changes in some other places would by required. So won't fix it. - Artur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126342/#review89476 ----------------------------------------------------------- On Gru 14, 2015, 12:15 po południu, Artur Puzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126342/ > ----------------------------------------------------------- > > (Updated Gru 14, 2015, 12:15 po południu) > > > Review request for Bluedevil and David Rosca. > > > Repository: bluez-qt > > > Description > ------- > > Fixed `warning: Missing reference on non-trivial type (*some*Ptr) > [-Wclazy-function-args-by-ref]` - without touching headers without `_p` > prefix or not in tests. > Fixed `warning: Reserve candidate [-Wclazy-reserve-candidates]` > Fixed Also one warning: warning: non-POD static (QString) and one warning: > QString(QLatin1String) in tests > > > Diffs > ----- > > autotests/fakebluez/deviceinterface.cpp 2f58f00 > autotests/inputtest.h ff8e8c4 > autotests/inputtest.cpp 7955ee6 > autotests/mediaplayertest.h 7427fbd > autotests/mediaplayertest.cpp 230b949 > src/adapter_p.h ab54315 > src/adapter_p.cpp 33fe048 > src/device_p.h ec1cdcd > src/device_p.cpp 2490b0c > src/imports/declarativeadapter.cpp 203a13b > src/imports/declarativemanager.cpp 634767c > src/manager_p.h 77cae10 > src/manager_p.cpp a343921 > src/obextransfer.cpp ffa3cdb > src/obextransfer_p.h 780755d > src/pendingcall.cpp cdd671b > src/utils.cpp 3e1e7c0 > tests/adaptersreceiver.h 3997906 > tests/adaptersreceiver.cpp 4ef0558 > tests/devicereceiver.h d0f7072 > tests/devicereceiver.cpp c6dde51 > > Diff: https://git.reviewboard.kde.org/r/126342/diff/ > > > Testing > ------- > > Automated tests passed. > > > Thanks, > > Artur Puzio > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
