-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126145/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 9:04 p.m.)
Status
------
This change has been marked as submitted.
Review request for Solid.
Changes
-------
Submitted with commit eca79138c15575f6f523a8680919b407f84da2e2 by Kai Uwe
Broulik to branch master.
Bugs: 352235
https://bugs.kde.org/show_bug.cgi?id=352235
Repository: powerdevil
Description
-------
Whenever Chrome plays sound it posts an inhibition. This is great, except that
it does that also when playing a short sound, such as when receiving a message.
This patch makes PowerDevil wait 5 seconds before actually enforcing the
inhibition. In any case I don't want to have the system wake up for any such
sort inhibitions.
Also cleanup, the add inhibition and add inhibition with explicit dbus service
methods were virtually identical.
Diffs
-----
daemon/powerdevilpolicyagent.h 256bf4c
daemon/powerdevilpolicyagent.cpp ec85189
Diff: https://git.reviewboard.kde.org/r/126145/diff/
Testing
-------
Started a video, stopped it right away. -> No inhibition shown in battery
monitor
Started a video, waited longer -> Inhibition appeared
stopped video again -> inhibition disappeared right away
Started playback in VLC while Chrome was playing -> got two inhibitions shortly
thereafter
Closed VLC -> Only Chrome's inhibition left
Asked for someone to send me a message, received it -> No inhibition was
enforced because the sound was too short
Thanks,
Kai Uwe Broulik
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
