> On Jan. 5, 2016, 1:10 p.m., Sebastian Kügler wrote: > > Please also disable it in the same way for the kwayland backend.
Already done, is there anything I should change before it can get merged? - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126630/#review90638 ----------------------------------------------------------- On Jan. 5, 2016, 1:08 p.m., Peter Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126630/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 1:08 p.m.) > > > Review request for Plasma, Solid, Daniel Vrátil, and Sebastian Kügler. > > > Repository: libkscreen > > > Description > ------- > > Logging is [enabled by default][1], there is no read to use setFilterRules > and [override][2] any user preferences in QtProject/qtlogging.ini. > > Keep unconditional logging enabled for the fake backend though, this > ensures that unit tests have log messages even if the user disabled all > other debug messages. > > [1]: https://doc.qt.io/qt-5/qloggingcategory.html#Q_LOGGING_CATEGORY > [2]: https://doc.qt.io/qt-5/qloggingcategory.html#configuring-categories > > > Diffs > ----- > > backends/kwayland/waylandbackend.cpp 0700e22 > backends/qscreen/qscreenbackend.cpp 56b5a7c > backends/xcbeventlistener.cpp ee415d7 > backends/xrandr/xrandr.cpp fae1dcc > backends/xrandr1.1/xrandr11.cpp 631bcc9 > src/debug_p.cpp 5934417 > > Diff: https://git.reviewboard.kde.org/r/126630/diff/ > > > Testing > ------- > > Tested on v5.5.2 (cherry-picked, ignored missing > backends/kwayland/waylandbackend.cpp). > > Test: > > 1. Have no kscreen related lines in ~/.config/QtProject/qtlogging.ini > 2. killall kscreen_backend_launcher > 3. Change brightness levels via the keyboard. (Result: > `RRNotify_OutputProperty` messages in `journalctl`) > 4. Add the following lines to qtlogging.ini: > ``` > kscreen.debug=false > kscreen.xrandr.debug=false > kscreen.xcb.helper.debug=false > ``` > 5. killall kscreen_backend_launcher > 6. Change brightness levels again. (Result: no log spam!) > > > Thanks, > > Peter Wu > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
