----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130115/#review103190 -----------------------------------------------------------
daemon/backends/upower/backlighthelper.cpp (line 86) <https://git.reviewboard.kde.org/r/130115/#comment68670> Code style: this is not correctly aligned. daemon/backends/upower/backlighthelper.cpp (line 89) <https://git.reviewboard.kde.org/r/130115/#comment68671> Since you're reusing the variable file here you have to close it first before calling file.setFileName(): ... file.close(); file.setFileName(BACKLIGHT_SYSFS_PATH + interface + "/type"); ... - Lamarque Souza On May 5, 2017, 7:28 a.m., AceLan Kao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130115/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 7:28 a.m.) > > > Review request for Solid. > > > Repository: powerdevil > > > Description > ------- > > While adjusting the brightness, if there are more than one graphics card > on the machine, then there might be more than one backlight interface > directories under /sys/backlight. Only one of them is active, and in the > code, KDE picks the first one in the list as the backlight device. It > might pick the wrong one if the active device is the second one. > So, we try skipping the disabled one and can fix the brightness issue on > some machines with more than one graphics cards. > > Signed-off-by: AceLan Kao <ace...@acelan.idv.tw> > > > Diffs > ----- > > daemon/backends/upower/backlighthelper.cpp > fb5f7ed991c320b242224930e0109d03cb328a6f > > Diff: https://git.reviewboard.kde.org/r/130115/diff/ > > > Testing > ------- > > > Thanks, > > AceLan Kao > >
