> On June 8, 2011, 1:14 p.m., Daniele Elmo Domenichelli wrote:
> > contact.cpp, lines 66-67
> > <http://git.reviewboard.kde.org/r/101541/diff/2/?file=24068#file24068line66>
> >
> >     Probably also the Contact::onPublishStateChanged and the 
> > Contact::publishStateChanged should be modified to reflect this change and 
> > emit the message as well

Yes, that's true. However, there's no way of storing this in the ontology for 
now, so I'll leave that for another patch.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101541/#review3765
-----------------------------------------------------------


On June 8, 2011, 12:23 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101541/
> -----------------------------------------------------------
> 
> (Updated June 8, 2011, 12:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Fix usage of deprecated tpqt4 signals.
> 
> 
> Diffs
> -----
> 
>   contact.cpp 4a1c5c61a06446f8fde80df71a396022b658e545 
> 
> Diff: http://git.reviewboard.kde.org/r/101541/diff
> 
> 
> Testing
> -------
> 
> unit tests still pass
> 
> 
> Thanks,
> 
> George
> 
>

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to