----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101918/#review4687 -----------------------------------------------------------
Ship it! main-widget.cpp <http://git.reviewboard.kde.org/r/101918/#comment4130> Minor english comment, it reads more naturally as: "Would you rather stay online or go offline" or "Do you want to stay online or would you rather go offline." main-widget.cpp <http://git.reviewboard.kde.org/r/101918/#comment4129> Maybe rename this to isPresencePlasmoidPresent, just for clarification when we have more plasmoids in future. - David On July 13, 2011, 3:08 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101918/ > ----------------------------------------------------------- > > (Updated July 13, 2011, 3:08 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This is the second part of the DBus-plasmoid-check patch. It checks if the > interface exists on dbus and is valid. If not, it displays a dialog asking > user what to do (see screenshot). It can also remember the preference. Please > also check spelling/grammar of the text. > > > Diffs > ----- > > main-widget.h 313f74f > main-widget.cpp 28c2d9a > > Diff: http://git.reviewboard.kde.org/r/101918/diff > > > Testing > ------- > > Tested both with plasmoid active and not active, works as expected. > > > Screenshots > ----------- > > The quit dialog > http://git.reviewboard.kde.org/r/101918/s/194/ > > > Thanks, > > Martin > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
