----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102282/#review6030 -----------------------------------------------------------
Ship it! Pretty cool patch. Does exactly what the desc says. Thanks. abstract-contact-delegate.cpp <http://git.reviewboard.kde.org/r/102282/#comment5314> I think this is a leftover from the other patch. No big deal, just watch out when you'll commit it. abstract-contact-delegate.cpp <http://git.reviewboard.kde.org/r/102282/#comment5315> Unnecessary empty line. - Martin On Aug. 10, 2011, 3 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102282/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2011, 3 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Make the abstractContactDelegate class actually behave like an abstract > class. Simplifying in the actual delegates. > > > Diffs > ----- > > abstract-contact-delegate.h b6dcfc861311f03f7af77cc426544e899cc2059a > abstract-contact-delegate.cpp 309910d672bd21bd15aec5e10f013dc32cb59f19 > contact-delegate-compact.h 4387e0c4f41ba0005ed239ac007d2bc35492ca0a > contact-delegate-compact.cpp 45cd28261f41290e14f58240fd999bb89cf1b31d > contact-delegate.h bc81bd40df15f17bde88a8ca95c172754fc09402 > contact-delegate.cpp 159894ff0080df02ba85b3cf52b2b2806bd8be56 > > Diff: http://git.reviewboard.kde.org/r/102282/diff > > > Testing > ------- > > > Thanks, > > David > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
