> On Aug. 26, 2011, 1:50 p.m., Martin Klapetek wrote:
> > Hi Jan, are there any updates on this patch? If so, please don't keep them 
> > for yourself :)

There are currently no updates of the patch as I don't have the time to work on 
it. If anyone wants to take this that's okay, if not I'll work on it at a later 
point.


- Jan Gerrit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102193/#review6031
-----------------------------------------------------------


On Aug. 3, 2011, 10:45 a.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102193/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2011, 10:45 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> The patch was created with the purpose to enable text copying by pressing 
> Ctrl+C. This was more complicated than I thought so I tried to implement a 
> new concept of handling the keys:
> My goal was to let the line edit and the view behave like there were one 
> widget regarding text selection. If text in the line edit is marked there is 
> no text marked in the view and vice versa. In order to achieve this I let the 
> widget which contains both handle the key events by connecting to a signal in 
> the two classes which get's emitted when a key is pressed.
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.h 0507128 
>   lib/adium-theme-view.cpp 0eb1090 
>   lib/chat-text-edit.h c086010 
>   lib/chat-text-edit.cpp ea96034 
>   lib/chat-widget.h 06e98a1 
>   lib/chat-widget.cpp 534ee1c 
> 
> Diff: http://git.reviewboard.kde.org/r/102193/diff
> 
> 
> Testing
> -------
> 
> I tested it for a day and there were no problems.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to