----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102568/#review6403 -----------------------------------------------------------
Ship it! Nice. I'm happy with the code, just change the string and please hold of with committing, I'll be posting a MainWidget refactor soon, hopefully tomorrow. main-widget.cpp <http://git.reviewboard.kde.org/r/102568/#comment5694> This could use some better explanatory caption as it's not clear what links that would open. "Open presence message link..." seems way too long (and thus making the menu really wide). So maybe "Presence Message Links"? Also the guidelines require us to use capitalization on menu items. main-widget.cpp <http://git.reviewboard.kde.org/r/102568/#comment5693> Someone suggested we use link parsing from Konversation, that guy whoeveritwas said, that it was tested against hundreds and hundreds of (im)possible address formats. We should take a look at it (as well as for the text-ui). - Martin On Sept. 10, 2011, 1:31 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102568/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2011, 1:31 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch adds a context menu in the contact custom menu you get when right > clicking a contact ONLY if the contact's presence message contains links, > otherwise no submenu is added. > > > Diffs > ----- > > main-widget.h bc3d1f8 > main-widget.cpp b477500 > > Diff: http://git.reviewboard.kde.org/r/102568/diff > > > Testing > ------- > > right clicked a contact with a link in his presence message > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
