----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102584/#review6435 -----------------------------------------------------------
Your diff is missing main-widget.cpp. avatar-button.h <http://git.reviewboard.kde.org/r/102584/#comment5708> This isn't really something public. avatar-button.cpp <http://git.reviewboard.kde.org/r/102584/#comment5709> This slot doesn't exist does it? I expect this to error and us to never see any errors. - David On Sept. 12, 2011, 9:53 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102584/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2011, 9:53 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This first patch moves avatar handling code outside of the class and > renames/moves some slots. > > > Diffs > ----- > > CMakeLists.txt b01272f > avatar-button.h PRE-CREATION > avatar-button.cpp PRE-CREATION > contact-delegate-overlay.cpp 5fe83ab > main-widget.h bc3d1f8 > main-widget.ui 73c4333 > models/accounts-model.cpp 17846bf > > Diff: http://git.reviewboard.kde.org/r/102584/diff > > > Testing > ------- > > > Thanks, > > Martin > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
