----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102306/#review6604 -----------------------------------------------------------
Ship it! - David On Sept. 17, 2011, 11:11 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102306/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2011, 11:11 p.m.) > > > Review request for Telepathy, George Kiagiadakis and David Edmundson. > > > Summary > ------- > > To handle metadata we will need another Tp::AbstactClientHandler for > streamtubes, therefore it's not good to use the FileTransferHandler class to > control the whole program > > This patch adds a new class (FileTransferControl) that works almost like a > singleton (without using K_GLOBAL_STATIC that doesn't work for QObjects) and > moves control of the flow of the program into this class. > > > Diffs > ----- > > src/CMakeLists.txt 9e84a8b9d427505a8babc79713ca41f1ec223a2a > src/filetransfer-handler.h 53b710a0bec0bf5dd10e70a53c59b90112c5e4e8 > src/filetransfer-handler.cpp 0e4624e46b4a702afa962dc3efcff37d4dae54ff > src/main.cpp eca8e2f77da9348bbbea4b7f8179f7142d1d5337 > src/telepathy-handler-application.h PRE-CREATION > src/telepathy-handler-application.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102306/diff > > > Testing > ------- > > Tried file transfers (just on my laptop) still exits when it is supposed to > exit. > > > Thanks, > > Daniele Elmo > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
