> On Nov. 28, 2011, 5:04 p.m., David Edmundson wrote: > > Discussing alternatives, you could also have just done: > > > > [ ]@yahoo.com > > > > and simply placed a label to the right on the text field. It's not a scary > > warning and is less confusing than changing people's inputs (IMHO) > > Martin Klapetek wrote: > Also possible. Though it changes people input only to what they have to > enter anyway. The fact that it changes also displayname is another thing (and > should be finally solved as well). > > Dario Freddi wrote: > However, quick question. How does that deal with, say, @yahoo.it, and in > general any other i18n'ed yahoo website? > > Martin Klapetek wrote: > I just checked with @yahoo.de - I can log in using my @yahoo.com > credentials for @yahoo.de - [email protected] works, although I've > registered only @yahoo.com. So I assume the part after '@' is not really > important. > > Daniele Elmo Domenichelli wrote: > How will you explain this to the users? > Even if it works, if you just leave @yahoo.com people will start > complaining that they cannot even enter their address > IMHO if we wanted to show the correct @yahoo.* part the best way is to > use a combo box where the @yahoo.com, and the @yahoo.<i18n> will always be > the first two entries, but since this part is completely unnecessary we could > just do > [ ]@yahoo.* (With an i18n'ed tooltip explaining this *) > And still remove the @yahoo.* part if the user adds it... > > Dario Freddi wrote: > TBH, the average user won't understand what * means. I think Martin's > approach is the best one: let the user input his full address if he finds it > natural, and we're gonna make our way through it. I'm giving a strong +1 to > Martin's approach, especially after the discussion.
+1 - Daniele Elmo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103281/#review8572 ----------------------------------------------------------- On Nov. 28, 2011, 1:01 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103281/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2011, 1:01 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Haze requires yahoo! account to be without the @yahoo.com part. This patch > removes that part if user adds it. It's imho better to do this than to put a > big scary WARNING! above the line edit. Our software appears smart. > > > This addresses bug 287190. > http://bugs.kde.org/show_bug.cgi?id=287190 > > > Diffs > ----- > > plugins/haze/yahoo-main-options-widget.h 592e582 > plugins/haze/yahoo-main-options-widget.cpp 25d163e > > Diff: http://git.reviewboard.kde.org/r/103281/diff/diff > > > Testing > ------- > > Successfully added a yahoo! account and connected. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
