----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103477/#review9119 -----------------------------------------------------------
Ship it! context-menu.h <http://git.reviewboard.kde.org/r/103477/#comment7542> Useless line here context-menu.cpp <http://git.reviewboard.kde.org/r/103477/#comment7543> These are not needed. context-menu.cpp <http://git.reviewboard.kde.org/r/103477/#comment7544> This is probably the wrong review to point this out, but this needs a check for removeDialog != null here after exec().... Something like: if (removeDialog.data()->exec() == QDialog::Accepted && removeDialog) { ... } - George Kiagiadakis On Dec. 19, 2011, 6:57 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103477/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2011, 6:57 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > That makes MainWidget significantly lighter and easier to manage as /the > widget/. Basically it just moves everything to ContextMenu, makes it friend > class of MainWidget and thus allowing access to the private members like > models etc. > > Next step is to separate the window logic from the widget itself and have the > contact list widget 100% reusable as-is. > > > Diffs > ----- > > CMakeLists.txt 5067b8b > context-menu.h PRE-CREATION > context-menu.cpp PRE-CREATION > main-widget.h b700a59 > main-widget.cpp 1a91516 > > Diff: http://git.reviewboard.kde.org/r/103477/diff/diff > > > Testing > ------- > > Everything works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
