-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103520/
-----------------------------------------------------------

(Updated Dec. 24, 2011, 5:37 p.m.)


Review request for Telepathy.


Changes
-------

Updated diff as a christmas gift!
All dnd related code is now in here, also the drag part. (Should I open a 
review for the common-internals part? It's about deleting all the now obsolete 
code.)
Restored the previous behavior, so you can drop a contact also on another one 
to add it to the group.


Description
-------

Adds support for drag and drop file transfer.
Before the model handled the drag and drop of contacts between groups,
but with reimplementing the drag*Event methods this stopped working so I moved 
the logic in the view.
(I will later clean up the model, I'm sure now there is unused code.)


This addresses bug 288560.
    http://bugs.kde.org/show_bug.cgi?id=288560


Diffs (updated)
-----

  contact-list-widget_p.h 9f9914616be89884f5d2971782fa0c3cf20d3ac0 
  contact-list-widget.h 85cac2a3912b127589757d95a32c64fa40444979 
  contact-list-widget.cpp 3d4362442eb37577fcf067b1bd24daa80222b196 

Diff: http://git.reviewboard.kde.org/r/103520/diff/diff


Testing
-------

Drag and dropping contacts to groups works.
Dropping one or more local file(s) over a contact starts the filetransfer(s).


Thanks,

Dominik Cermak

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to